Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear numeric up down on dispenser events #198

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Clear numeric up down on dispenser events #198

merged 1 commit into from
Dec 21, 2023

Conversation

glopesdev
Copy link
Contributor

This PR ensures the numeric up down is cleared on DispenserEventControl after issuing a dispenser action, e.g. refill or reset. Furthermore, we introduced a condition where actions are only sent for non-zero values to avoid accidentally repeating commands.

Fixes SainsburyWellcomeCentre/aeon_experiments#113

@glopesdev glopesdev added the fix Pull request that fixes an issue label Dec 21, 2023
@glopesdev glopesdev merged commit 079527b into main Dec 21, 2023
1 check passed
@glopesdev glopesdev mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkbhagatio jkbhagatio jkbhagatio approved these changes

@aspaNeuro aspaNeuro Awaiting requested review from aspaNeuro

Assignees
No one assigned
Labels
fix Pull request that fixes an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear numeric up down control when refilling or resetting dispenser
2 participants
@glopesdev @jkbhagatio